Hi,
On 25-Oct-24 9:30 PM, Mario Limonciello wrote:
> In order to prepare for having support for multiple platform handlers
> a list will be needed to iterate over them for various platform
> profile handler calls.
>
> Tested-by: Matthew Schwartz <matthew.schwartz@xxxxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Regards,
Hans
> ---
> drivers/acpi/platform_profile.c | 5 ++++-
> include/linux/platform_profile.h | 1 +
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index c24744da20916..0c60fc970b6e8 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -10,6 +10,7 @@
> #include <linux/sysfs.h>
>
> static struct platform_profile_handler *cur_profile;
> +static LIST_HEAD(platform_profile_handler_list);
> static DEFINE_MUTEX(profile_lock);
>
> static const char * const profile_names[] = {
> @@ -198,6 +199,7 @@ int platform_profile_register(struct platform_profile_handler *pprof)
> mutex_unlock(&profile_lock);
> return err;
> }
> + list_add_tail(&pprof->list, &platform_profile_handler_list);
>
> cur_profile = pprof;
> mutex_unlock(&profile_lock);
> @@ -207,8 +209,9 @@ EXPORT_SYMBOL_GPL(platform_profile_register);
>
> int platform_profile_remove(struct platform_profile_handler *pprof)
> {
> - sysfs_remove_group(acpi_kobj, &platform_profile_group);
> + list_del(&pprof->list);
>
> + sysfs_remove_group(acpi_kobj, &platform_profile_group);
> mutex_lock(&profile_lock);
> cur_profile = NULL;
> mutex_unlock(&profile_lock);
> diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
> index 58279b76d740e..9ded63a9ae6f1 100644
> --- a/include/linux/platform_profile.h
> +++ b/include/linux/platform_profile.h
> @@ -29,6 +29,7 @@ enum platform_profile_option {
> struct platform_profile_handler {
> const char *name;
> unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
> + struct list_head list;
> int (*profile_get)(struct platform_profile_handler *pprof,
> enum platform_profile_option *profile);
> int (*profile_set)(struct platform_profile_handler *pprof,
