On Mon, Oct 21, 2024 at 10:46:38AM -0400, Gregory Price wrote: > On Mon, Oct 21, 2024 at 01:12:26PM +0200, David Hildenbrand wrote: > > > > > + /* Consider hotplug advisement value (if set) */ > > > + order = memblock_probe_size_order(); > > > > "size_order" is a very weird name. Just return a size? > > > > memory_block_advised_max_size() > > > > or sth like that? > > > > There isn't technically an overall "max block size", nor any alignment > requirements - so order was a nice way of enforcing 2-order alignment > while also having the ability to get a -1/-EBUSY/whatever out. > > I can change it if it's a big sticking point - but that's my reasoning. > maybe change to memory_block_advise_max_size memory_block_probe_max_size but still take in / return an order? ~Gregory