On Tue, Oct 08, 2024 at 06:10:28PM +0200, Javier Carrasco wrote: > The 'led' fwnode_handle within fwnode_for_each_child_node() must be > released upon early exits by means of an explicit call to > fwnode_handle_put(), which in this case is missing. > > Instead of adding the missing call, and considering that this driver was > recently introduced, use a scoped variant of the loop to automatically > decrement the child's refcount when it goes out of scope. > > Note that the _avaialable_ version of the loop has been used, as there > is no apparent reason to walk over unavailable nodes. > > Fixes: 94a2a84f5e9e ("net: dsa: mv88e6xxx: Support LED control") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Andrew