[AMD Official Use Only - AMD Internal Distribution Only]
> -----Original Message-----
> From: Mario Limonciello <superm1@xxxxxxxxxx>
> Sent: Tuesday, August 27, 2024 5:14 AM
> To: Borislav Petkov <bp@xxxxxxxxx>; Shenoy, Gautham Ranjal
> <gautham.shenoy@xxxxxxx>; Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT) <x86@xxxxxxxxxx>;
> Rafael J . Wysocki <rafael@xxxxxxxxxx>; open list:X86 ARCHITECTURE (32-BIT
> AND 64-BIT) <linux-kernel@xxxxxxxxxxxxxxx>; open list:ACPI <linux-
> acpi@xxxxxxxxxxxxxxx>; open list:CPU FREQUENCY SCALING FRAMEWORK
> <linux-pm@xxxxxxxxxxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; Yuan, Perry <Perry.Yuan@xxxxxxx>
> Subject: [PATCH 3/8] ACPI: CPPC: Adjust debug messages in
> amd_set_max_freq_ratio() to warn
>
> From: Mario Limonciello <mario.limonciello@xxxxxxx>
>
> If the boost ratio isn't calculated properly for the system for any reason this
> can cause other problems that are non-obvious.
>
> Raise all messages to warn instead.
>
> Suggested-by: Perry Yuan <Perry.Yuan@xxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> arch/x86/kernel/acpi/cppc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c index
> 1d631ac5ec328..e94507110ca24 100644
> --- a/arch/x86/kernel/acpi/cppc.c
> +++ b/arch/x86/kernel/acpi/cppc.c
> @@ -75,17 +75,17 @@ static void amd_set_max_freq_ratio(void)
>
> rc = cppc_get_perf_caps(0, &perf_caps);
> if (rc) {
> - pr_debug("Could not retrieve perf counters (%d)\n", rc);
> + pr_warn("Could not retrieve perf counters (%d)\n", rc);
> return;
> }
>
> rc = amd_get_boost_ratio_numerator(0, &highest_perf);
> if (rc)
> - pr_debug("Could not retrieve highest performance\n");
> + pr_warn("Could not retrieve highest performance\n");
> nominal_perf = perf_caps.nominal_perf;
>
> if (!nominal_perf) {
> - pr_debug("Could not retrieve nominal performance\n");
> + pr_warn("Could not retrieve nominal performance\n");
> return;
> }
>
> @@ -93,7 +93,7 @@ static void amd_set_max_freq_ratio(void)
> /* midpoint between max_boost and max_P */
> perf_ratio = (perf_ratio + SCHED_CAPACITY_SCALE) >> 1;
> if (!perf_ratio) {
> - pr_debug("Non-zero highest/nominal perf values led to a 0
> ratio\n");
> + pr_warn("Non-zero highest/nominal perf values led to a 0
> ratio\n");
> return;
> }
>
> --
> 2.43.0
>
LGTM, it is good to show the warning message once there are some perf values are invalid.
That will help to debug the issue from customer report log.
Reviewed-by: Perry Yuan <perry.yuan@xxxxxxx>
Best Regards.
Perry.
