On Wed, 2024-08-21 at 14:36 +0800, Koba Ko wrote: > > On 8/21/24 14:33, Zhang, Rui wrote: > > Yeah, but I mean pr_err() may be overkill if the driver is still > > functional. > > how about replace with pr_warn? when it fails, 1. the address space handler still returns AE_OK (is it right?) 2. I don't see how PRM_HANDLER_GUID_NOT_FOUND prm_status is handled So, if it is a critical error, we should fail the prmt probe immediately. If it is not, we can let space handler returns AE_OK like you do in this patch, and in this case, even a pr_info() is sufficient IMV. thanks, rui
