On 14.08.2024 8:16 AM, Krzysztof Kozlowski wrote: > On 13/08/2024 16:27, Konrad Dybcio wrote: >> On 11.08.2024 4:28 PM, Krzysztof Kozlowski wrote: >>> On 10/08/2024 03:28, Konrad Dybcio wrote: >>>> From: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx> >>>> >>>> Add bindings for the Surface System Aggregator Module (SAM/SSAM), the >>>> Microsoft Surface-standard Embedded Controller, used on both x86- and >>>> Qualcomm-based devices. >>>> >>>> It provides a plethora of functions, depending on what's wired up to >>>> it. That includes but is not limited to: fan control, keyboard/touchpad >>>> support, thermal sensors, power control, special buttons, tablet mode. >>>> >>>> Signed-off-by: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx> >>>> --- [...] >>>> + current-speed: >>>> + description: The baudrate in bits per second of the device as it comes >>>> + online, current active speed. >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> >>> This should be just "current-speed: true", because the type will be >>> brought by serial schema. We should however have some schema with >>> peripheral properties for serial devices. I'll come with something. >> >> I suppose I should just include: >> >> https://lore.kernel.org/linux-serial/20240811-dt-bindings-serial-peripheral-props-v1-0-1dba258b7492@xxxxxxxxxx/ > > > You could, but then your patchset will depend on mine, so instead I > propose just "current-speed: true" and later (next release) we will add > $ref to serial-peripheral-props. You got it! Konrad
