On 10.08.2024 3:47 AM, Maximilian Luz wrote: > On 8/10/24 3:28 AM, Konrad Dybcio wrote: >> From: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx> > > [...] > >> @@ -299,7 +302,7 @@ static const struct attribute_group ssam_sam_group = { >> }; >> -/* -- ACPI based device setup. ---------------------------------------------- */ >> +/* -- Serial device setup. ------------------------------------------------- */ > > One more :) Right, cursor at 80 != 80-long :P [...] > Are these two changes required? Surface 3 power and SAN should AFAIK be > fairly "legacy" and ACPI-only drivers, which I don't expect to be used > on any of the new ARM devices (apart from there probably being other > changes required to make them work with DT). > > I think with that addressed, it should be fine. I'll give it a spin > tomorrow and send in my r-b and t-b (assuming everything goes well). No, I went overly defensive here. Will drop for v3 next week. Konrad