Re: [PATCH v3 16/26] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mike Rapoport <rppt@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v3 16/26] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Tue, 6 Aug 2024 15:14:52 +0200
Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Davidlohr Bueso <dave@xxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>, Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Samuel Holland <samuel.holland@xxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Zi Yan <ziy@xxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx
In-reply-to: <20240801060826.559858-17-rppt@kernel.org>
Organization: Red Hat
References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-17-rppt@kernel.org>
User-agent: Mozilla Thunderbird

On 01.08.24 08:08, Mike Rapoport wrote:

From: "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx>

CPU id cannot be negative.

Making it unsigned also aligns with declarations in
include/asm-generic/numa.h used by arm64 and riscv and allows sharing
numa emulation code with these architectures.

Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Tested-by: Zi Yan <ziy@xxxxxxxxxx> # for x86_64 and arm64
---


Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb

References:
- [PATCH v3 00/26] mm: introduce numa_memblks
  - From: Mike Rapoport
- [PATCH v3 16/26] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned
  - From: Mike Rapoport

Prev by Date: Re: [PATCH v3 15/26] x86/numa_emu: use a helper function to get MAX_DMA32_PFN
Next by Date: Re: [PATCH v3 17/26] mm: introduce numa_memblks
Previous by thread: [PATCH v3 16/26] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned
Next by thread: [PATCH v3 17/26] mm: introduce numa_memblks
Index(es):
- Date
- Thread

[Index of Archives] [Linux IBM ACPI] [Linux Power Management] [Linux Kernel] [Linux Laptop] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]