This series aims to clarify the use cases of: - device_for_each_child_node[_scoped]() - fwnode_for_each_available_child_node[_scoped]() to access firmware nodes. There have been multiple discussions [1][2] about what the first macro implies in the sense of availability, and a number of users have opted for the second macro in cases where the first one should have been preferred. The second macro is intended to be used over child nodes of a firmware node, not direct child nodes of the device node. Instead, those users retrieve the fwnode member from the device struct just to have access to a macro that explicitly indicates node availability. That workaround is not necessary because `device_for_each_child_node()` implies availability for the existing backends (ACPI, DT, swnode). This series does not cover other points discussed in [2] like addressing uses of `fwnode_for_each_child_node()` where `device_*` should have been used, using the `_avaialble_` variant of the fwnode loop whenever possible, or adding new `_scoped` macros. Such points will be covered by subsequent series to keep focus on the "availability" issue. The conversion has been validated with an LTC2992 hwmon sensor, which is one of the affected drivers. The rest of the drivers could only be compiled and checked with static-analysis tools. Link: https://lore.kernel.org/all/20211205190101.26de4a57@jic23-huawei/ [1] Link: https://lore.kernel.org/all/20240523-fwnode_for_each_available_child_node_scoped-v2-0-701f3a03f2fb@xxxxxxxxx/ [2] Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> --- Changes in v3: - Rebase to next/20240805 and drop applied patches. - mvpp2: fix typos in commit description. - mvpp2: add patch to use port_count instead of node iteration. - Link to v2: https://lore.kernel.org/r/20240721-device_for_each_child_node-available-v2-0-f33748fd8b2d@xxxxxxxxx Changes in v2: - [1/6] property.h: drop "if found" from the description of device_for_each_child_node() - [3/6] bd2607mvv.c: fix child node usage. - Link to v1: https://lore.kernel.org/r/20240706-device_for_each_child_node-available-v1-0-8a3f7615e41c@xxxxxxxxx --- Javier Carrasco (4): device property: document device_for_each_child_node macro leds: pca995x: use device_for_each_child_node() to access device child nodes net: mvpp2: use port_count to remove ports net: mvpp2: use device_for_each_child_node() to access device child nodes drivers/leds/leds-pca995x.c | 15 ++++-------- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 31 +++++++------------------ include/linux/property.h | 10 ++++++++ 3 files changed, 24 insertions(+), 32 deletions(-) --- base-commit: d6dbc9f56c3a70e915625b6f1887882c23dc5c91 change-id: 20240701-device_for_each_child_node-available-1c1eca4b6495 Best regards, -- Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
