Hi Hans, On Mon, Jul 29, 2024 at 1:29 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 7/29/24 1:15 PM, Hans de Goede wrote: > > Hi Rafael, > > > > There are 2 bug reports: > > > > 1. Brightness up/down key-presses no longer working on LG laptop (acpi-video related): > > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/thread/V2KWAGZIAX4TOWPCH6A6FSIT66PR3KMZ/ > > > > 2. EC related ACPI errors and bad performance: > > https://bugzilla.redhat.com/show_bug.cgi?id=2298938 > > > > Both of which started with 6.9.7 which has the 2 commits related to "EC: Install > > address space handler at the namespace root" from 6.10 backported: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/acpi?h=v6.9.7&id=2b2b0ac1533d790690d6d28899f01a2924d54d4d > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/acpi?h=v6.9.7&id=9750135f2f326879889ed60ccd68b96572dfa6ee > > > > i have build a test 6.9.9 kernel with these 2 reverted and 1. is confirmed to be fixed > > by reverting these 2 commits. Although the user does report an IRQ storm on the ACPI IRQ > > (IRQ 9) related to thunderbolt after this. > > > > I have not yet got confirmation that the second bug is also resolved by the commits. > > ... resolved by *reverting* the commits. > > > Either way it looks like we need to dig into this and figure out what is causing > > these EC related regressions. Right, so I looked at the dmesg output in 2. and saw that the EC errors were reported right after enabling the EC for the first time in acpi_ec_dsdt_probe(). Because acpi_ec_dsdt_probe() passes true as the last argument to acpi_ec_setup(), it will evaluate _REG everywhere at this point, but previously it only evaluated _REG in the EC scope. In the ECDT case, the _REG evaluation is deferred until the EC has been found in the namespace, so maybe that's the right time to evaluate EC opregions _REG in general. So one thing to try may be to pass "false" to acpi_ec_setup() in acpi_ec_dsdt_probe(). > I'm wondering if maybe this is also somewhat related to commit e2ffcda16290 ("ACPI: OSL: > Allow Notify () handlers to run on all CPUs") ? > > I guess not though since this started in 6.9.7 and 6.9.6 is fine. > > I did recently submit an unrelated fix caused by e2ffcda16290: > > https://lore.kernel.org/platform-driver-x86/20240729110030.8016-1-hdegoede@xxxxxxxxxx/ None of the above look like they are processor-related, though. Thanks!
