[rafael-pm:bleeding-edge 179/184] drivers/thermal/intel/intel_quark_dts_thermal.c:258:16: error: expected ':' before 'return'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head:   87efced4091268c3ec327c53829b5e375be155dd
commit: fac8bf59e782ac74bb54d8427581f725bba8a769 [179/184] thermal: trip: Pass trip pointer to .set_trip_temp() thermal zone callback
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240710/202407100927.FM8ya0gq-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240710/202407100927.FM8ya0gq-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407100927.FM8ya0gq-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

   drivers/thermal/intel/intel_quark_dts_thermal.c: In function 'sys_set_trip_temp':
>> drivers/thermal/intel/intel_quark_dts_thermal.c:258:16: error: expected ':' before 'return'
     258 |         default
         |                ^
         |                :
     259 |                 return -EINVAL;
         |                 ~~~~~~
>> drivers/thermal/intel/intel_quark_dts_thermal.c:251:9: warning: enumeration value 'THERMAL_TRIP_ACTIVE' not handled in switch [-Wswitch]
     251 |         switch (trip->type) {
         |         ^~~~~~
>> drivers/thermal/intel/intel_quark_dts_thermal.c:251:9: warning: enumeration value 'THERMAL_TRIP_PASSIVE' not handled in switch [-Wswitch]


vim +258 drivers/thermal/intel/intel_quark_dts_thermal.c

   244	
   245	static inline int sys_set_trip_temp(struct thermal_zone_device *tzd,
   246					    const struct thermal_trip *trip,
   247					    int temp)
   248	{
   249		unsigned int trip_index;
   250	
 > 251		switch (trip->type) {
   252		case THERMAL_TRIP_HOT:
   253			trip_index = QRK_DTS_ID_TP_HOT;
   254			break;
   255		case THERMAL_TRIP_CRITICAL:
   256			trip_index = QRK_DTS_ID_TP_CRITICAL;
   257			break;
 > 258		default
   259			return -EINVAL;
   260		}
   261	
   262		return update_trip_temp(thermal_zone_device_priv(tzd), trip_index, temp);
   263	}
   264	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux