On Mon, 8 Jul 2024 14:10:25 +0200 Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote: > Em Mon, 8 Jul 2024 13:32:34 +0200 > Borislav Petkov <bp@xxxxxxxxx> escreveu: > > > On Mon, Jul 08, 2024 at 01:18:10PM +0200, Mauro Carvalho Chehab wrote: > > > From: Daniel Ferguson <danielf@xxxxxxxxxxxxxxxxxxxxxx> > > > > > > This prevents the unnecessary inclusion of ARM specific RAS error > > > > s/This prevents/Prevent/ > > > > Avoid having "This patch" or "This commit" or "This does <bla>" in the commit > > message. It is tautologically useless. > > > > "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" > > instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy > > to do frotz", as if you are giving orders to the codebase to change > > its behaviour." > > > > From Documentation/process/submitting-patches.rst > > > > > handling routines in non-ARM platforms. > > > > Ok, this does "something". Why does it do it? > > > > Otherwise it won't build on other architectures or is it going to cause code > > bloat or why are we doing this? > > Probably a better description would be: > > RAS: ACPI: APEI: add conditional compilation to ARM error report functions > > Don't include ARM Processor specific error handling routines in > non-ARM platforms, preparing it to the next patch, as arm-specific > kAPI symbols will be used, thus avoiding build breakages when ARM > is not selected. > > [mchehab: avoid unneeded ifdefs and fix coding style issues] > Signed-off-by: Daniel Ferguson <danielf@xxxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> With that change log seems fine to me. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > This patch itself just add conditionals to optimize out code on > non-ARM architectures. The next one will add some ARM-specific bits > inside ARM processor CPER trace, thus causing compilation breakages > on non-ARM, due to arm-specific kAPI bits that will be used then. > > Thanks, > Mauro
