On Mon, Jun 24, 2024 at 10:31:01AM +0800, Youwan Wang wrote: > amba_register_dummy_clk() is called only once from acpi_amba_init() > and acpi_amba_init() itself is called once during the initialisation. > amba_dummy_clk can't be initialised before this in any other code > path and hence the check for already registered amba_dummy_clk is > not necessary. Drop the same. > > Signed-off-by: Youwan Wang <youwan@xxxxxxxxxxxx> > Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx> > Acked-by: Hanjun Guo <guohanjun@xxxxxxxxxx> > --- > v1->v2->v3: Modify the commit log description > v3->v4: Update the commit message suggested by Sudeep; > Add Acked-by from Sudeep; > +Cc ARM64 maintainers Catalin and Will. I think I have told you many time now and you are missing to understand few basic stuff. So I suggest to give `Documentation/process/submitting-patches.rst` under the kernel source a read and especially the section `The canonical patch format` Ideally this patch should have been v5 as you added Hanjun's Ack Also "v1->v2->v3: Modify the commit log description" makes no sense. The changelog should list all the deltas like: v4->v5: - <blah3 blah3> v3->v4: - <blah2 blah2> v2->v3: - <blah1 blah1> v1->v2: - <blah blah> Anyways, it is only for your learning and future references. -- Regards, Sudeep
