Just sent a new patch with a description. Thanks! Asmaa > -----Original Message----- > From: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > Sent: Wednesday, June 5, 2024 8:07 PM > To: Asmaa Mnebhi <asmaa@xxxxxxxxxx> > Cc: linux-pm@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v1 1/1] power: reset: pwr-mlxbf: support graceful > shutdown > > Hi, > > On Mon, Apr 29, 2024 at 04:45:19PM -0400, Asmaa Mnebhi wrote: > > Replace the low power mode with a graceful shutdown. > > That's a summary of what the code changes, but the commit description is > missing an important information. It's not obvious why this change is needed. > Especially considering the past of this driver: It started with > > reset => emergency reset > low power => poweroff HID event > > Then got changed to > > reset => reset HID event > low power => poweroff HID event > > And now is further changed to > > reset => reset HID event > low power => emergency poweroff > > I don't think it's sensible to continue this ping pong, so please properly > describe what those IRQs are for and why further changes are needed. > > Greetings, > > -- Sebastian
