On 6/5/24 7:28 PM, Huang Ying wrote:
> To improve the readability of the code via replacing the magic number
> "1" with ACCESS_COORDINATE_CPU when appropriate. No functionality
> change.
>
> Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
> Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Bharata B Rao <bharata@xxxxxxx>
> Cc: Alistair Popple <apopple@xxxxxxxxxx>
> Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx>
Thanks for this. Looks like I missed a few.
Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> ---
> drivers/acpi/numa/hmat.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
> index 2c8ccc91ebe6..febd9e51350b 100644
> --- a/drivers/acpi/numa/hmat.c
> +++ b/drivers/acpi/numa/hmat.c
> @@ -408,7 +408,7 @@ static __init void hmat_update_target(unsigned int tgt_pxm, unsigned int init_px
> if (target && target->processor_pxm == init_pxm) {
> hmat_update_target_access(target, type, value,
> ACCESS_COORDINATE_LOCAL);
> - /* If the node has a CPU, update access 1 */
> + /* If the node has a CPU, update access ACCESS_COORDINATE_CPU */
> if (node_state(pxm_to_node(init_pxm), N_CPU))
> hmat_update_target_access(target, type, value,
> ACCESS_COORDINATE_CPU);
> @@ -948,7 +948,7 @@ static int hmat_set_default_dram_perf(void)
> target = find_mem_target(pxm);
> if (!target)
> continue;
> - attrs = &target->coord[1];
> + attrs = &target->coord[ACCESS_COORDINATE_CPU];
> rc = mt_set_default_dram_perf(nid, attrs, "ACPI HMAT");
> if (rc)
> return rc;
> @@ -975,7 +975,7 @@ static int hmat_calculate_adistance(struct notifier_block *self,
> hmat_update_target_attrs(target, p_nodes, ACCESS_COORDINATE_CPU);
> mutex_unlock(&target_lock);
>
> - perf = &target->coord[1];
> + perf = &target->coord[ACCESS_COORDINATE_CPU];
>
> if (mt_perf_to_adistance(perf, adist))
> return NOTIFY_OK;
