On Tue, May 28, 2024 at 12:42 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > On Mon, May 27, 2024 at 10:24 PM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > > > Since we have dev_is_pnp() macro that utilises the address of pnp_bus_type > > variable, the users, which can be compiled as modules, will be failed to > > build. Export the variable to the modules to prevent build breakage. ... > > +EXPORT_SYMBOL(pnp_bus_type); > > Why not EXPORT_SYMBOL_GPL()? To be consistent with the rest, but in any case Christoph suggested something else, where _GPL is assumed to be. -- With Best Regards, Andy Shevchenko