On Tue, May 28, 2024 at 10:12:31AM +0300, Andy Shevchenko wrote: > > NAK. Please move dev_is_pnp out of line and export it (as > > EXPORT_SYMBOL_GPL), please. bus types should be private unless we have > > really good reasons for them not to be private. > > FWIW, it's not private, it's just not exported to the modules. Are you > suggesting to hide the bus type completely to make it static? If so, > this is out of scope of this fix. Not exporting it is the most important bit. Making it private would be even better of course.