Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 5/16/24 5:11 PM, Thomas Zimmermann wrote:
> Hi
> Am 16.05.24 um 17:03 schrieb Hans de Goede:
>> Hi,
>> On 5/16/24 3:04 PM, Rafael J. Wysocki wrote:
>>> CC Hans who has been doing the majority of the ACPI video work.
>>> On Thu, May 16, 2024 at 2:43 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
>>>> Commit 2fd001cd3600 ("arch: Rename fbdev header and source files")
>>>> renames the video source files under arch/ such that they does not
>>>> refer to fbdev any longer. The new files named video.o conflict with
>>>> ACPI's video.ko module.
>>> And surely nobody knew or was unable to check upfront that there was a
>>> video.ko already in the kernel.
>> Sorry, but nack for this change. I very deliberately kept the module-name
>> as video when renaming the actual .c file from video.c to acpi_video.c
>> because many people pass drivers/video/acpi_video.c module arguments
>> on the kernel commandline using video.param=val .
>> Try e.g. doing a duckduckgo search for 1 off:
>> "video.only_lcd"
>> "video.allow_duplicates"
>> "video.brightness_switch_enabled"
> Ok, that makes sense. I'll rename the other files.

Great, thank you.



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux