Re: [PATCH] Force acpi_new_pts_ordering for ASUS A6VC laptop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +static int __init asus_suspend_order(const struct dmi_system_id *d)
> +{
> +	printk(KERN_WARNING PREFIX "%s detected, "
> +		"acpi_new_pts_ordering is force enabled\n", d->ident);
> +	new_pts_ordering = true;
> +	return 0;

Given all you're doing here is just changing the ordering,
'asus_suspend_order' doesn't strike me as the right name for this function
since:

1) This clearly isn't the case for all Asus boards.

2) Perhaps something like 'new_suspend_order' would be a better name for
this function (e.g. if others want to use DMI to do this for non-Asus
boards).

-Carlos
-- 
E-Mail: carlos@xxxxxxxxxxxxxxxxxxx
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux