> > > And the return value of thermal_zone_device_register is also > > misused. > I guess you didn't fix this one, right? > Len, please apply this patch.:) Indeed, I did not fix this one. So your patch should be used in this case. julia > > > Check the return value of thermal zone device registration correctly. > > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> > --- > drivers/acpi/thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/acpi/thermal.c > =================================================================== > --- linux-2.6.orig/drivers/acpi/thermal.c > +++ linux-2.6/drivers/acpi/thermal.c > @@ -1125,7 +1125,7 @@ static int acpi_thermal_register_thermal > tz->trips.active[i].flags.valid; i++, trips++); > tz->thermal_zone = thermal_zone_device_register("ACPI thermal zone", > trips, tz, &acpi_thermal_zone_ops); > - if (!tz->thermal_zone) > + if (IS_ERR(tz->thermal_zone)) > return -ENODEV; > > result = sysfs_create_link(&tz->device->dev.kobj, > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html