Re: [PATCH v7 01/16] ACPI: processor: Simplify initial onlining to use same path for cold and hotplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 2024/4/18 21:53, Jonathan Cameron wrote:
Separate code paths, combined with a flag set in acpi_processor.c to
indicate a struct acpi_processor was for a hotplugged CPU ensured that
per CPU data was only set up the first time that a CPU was initialized.
This appears to be unnecessary as the paths can be combined by letting
the online logic also handle any CPUs online at the time of driver load.

Motivation for this change, beyond simplification, is that ARM64
virtual CPU HP uses the same code paths for hotplug and cold path in
acpi_processor.c so had no easy way to set the flag for hotplug only.
Removing this necessity will enable ARM64 vCPU HP to reuse the existing
code paths.

Leave noisy pr_info() in place but update it to not state the CPU
was hotplugged.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

v7: No change.
v6: New patch.
RFT: I have very limited test resources for x86 and other
architectures that may be affected by this change.
  drivers/acpi/acpi_processor.c   |  1 -
  drivers/acpi/processor_driver.c | 44 ++++++++++-----------------------
  include/acpi/processor.h        |  2 +-
  3 files changed, 14 insertions(+), 33 deletions(-)

Nice simplification,

Reviewed-by: Hanjun Guo <guohanjun@xxxxxxxxxx>


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux