On Fri, Mar 29, 2024 at 7:55 PM Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > > Uwe Kleine-König wrote: > > The einj_driver driver is registered using platform_driver_probe(). In > > this case it cannot get unbound via sysfs and it's ok to put the remove > > callback into an exit section. To prevent the modpost warning about > > einj_driver referencing .exit.text, mark the driver struct with > > __refdata and explain the situation in a comment. > > > > This is an improvement over commit a24118a8a687 ("ACPI: APEI: EINJ: mark > > remove callback as non-__exit") which recently addressed the same issue, > > but picked a less optimal variant. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > Thanks for the explanation Uwe, this makes sense. > > Rafael, do you want to pick this one up as well? > > Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> Applied as 6.10 material, thanks!