On Wed, Apr 03, 2024 at 12:54:19PM +0300, Andy Shevchenko wrote: > On Wed, Apr 03, 2024 at 03:41:29PM +0800, Guanbing Huang wrote: One more thing, the Subject should start with "serial: port: ..." And also should have PNP IRQ (capitalized). > > The function __uart_read_properties doesn't cover pnp devices, so add irq > > __uart_read_properties() > > PNP > IRQ > > > processing for pnp devices in the branch. > > PNP > > ... > > > #include <linux/property.h> > > #include <linux/serial_core.h> > > #include <linux/spinlock.h> > > +#include <linux/pnp.h> > > Keep it ordered (in this context it should go before property.h). -- With Best Regards, Andy Shevchenko
