On Tue, 27 Feb 2024 14:14:35 -0600 Ben Cheatham <benjamin.cheatham@xxxxxxx> wrote: > This patch also had an outdated commit message (still referenced the einj-cxl module). > The patch with the updated commit message is below. I also made a tiny change to > the format specifier of the einj_inject file to "0x%llx\n" from "%llx\n". > > Thanks, > Ben > > From 321129893da9129473c447772a461c1a4e9e0e9d Mon Sep 17 00:00:00 2001 > From: Ben Cheatham <Benjamin.Cheatham@xxxxxxx> > Date: Fri, 16 Feb 2024 11:17:01 -0600 > Subject: [PATCH v14 3/4] cxl/core: Add CXL EINJ debugfs files > > Export CXL helper functions in einj-cxl.c for getting/injecting > available CXL protocol error types to sysfs under kernel/debug/cxl. > > The kernel/debug/cxl/einj_types file will print the available CXL > protocol errors in the same format as the available_error_types > file provided by the einj module. The > kernel/debug/cxl/$dport_dev/einj_inject file is functionally the same > as the error_type and error_inject files provided by the EINJ module, > i.e.: writing an error type into $dport_dev/einj_inject will inject > said error type into the CXL dport represented by $dport_dev. > > Signed-off-by: Ben Cheatham <Benjamin.Cheatham@xxxxxxx> LGTM other than not sending patches like this as tooling won't pick them up! Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>