On Tue, 20 Feb 2024 16:12:39 -0700
Dave Jiang <dave.jiang@xxxxxxxxx> wrote:
> Add read/write latencies and bandwidth sysfs attributes for the enabled CXL
> region. The bandwidth is the aggregated bandwidth of all devices that
> contribute to the CXL region. The latency is the worst latency of the
> device amongst all the devices that contribute to the CXL region.
>
> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
One trivial comment follows though it applies in a couple of places.
Up to you whether you act on it.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> +
> +ACCESS_ATTR_RO(1, read_bandwidth);
> +ACCESS_ATTR_RO(1, read_latency);
> +ACCESS_ATTR_RO(1, write_bandwidth);
> +ACCESS_ATTR_RO(1, write_latency);
> +
> +static struct attribute *access1_coordinate_attrs[] = {
> + ACCESS_ATTR_DECLARE(1, read_bandwidth),
> + ACCESS_ATTR_DECLARE(1, write_bandwidth),
> + ACCESS_ATTR_DECLARE(1, read_latency),
> + ACCESS_ATTR_DECLARE(1, write_latency),
> + NULL,
I'd drop that comma on the trailing entry, but there are others
already in this file that do have it, so up to you.
