On Mon, Mar 04, 2024 at 10:57:39AM -0600, Pierre-Louis Bossart wrote: > > +/* Values for link_type field above */ > > + > > +#define ACPI_NHLT_LINKTYPE_HDA 0 > > +#define ACPI_NHLT_LINKTYPE_DSP 1 > > +#define ACPI_NHLT_LINKTYPE_PDM 2 > > +#define ACPI_NHLT_LINKTYPE_SSP 3 > > +#define ACPI_NHLT_LINKTYPE_SLIMBUS 4 > > +#define ACPI_NHLT_LINKTYPE_SDW 5 > > +#define ACPI_NHLT_LINKTYPE_UAOL 6 > > More than half of those values are not used. Is there really any benefit > in exposing them? Sometimes a code is the (only) documentation. Since it's a global header and part of ACPICA we probably better to expose all bits that are defined. -- With Best Regards, Andy Shevchenko