On Fri, Feb 23, 2024 at 4:57 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > A few APIs that belong specifically to the fw_devlink APIs It would be better to say which functions specifically you mean here. > - are exposed to others without need This is not particularly precise. I guess you mean that they could be static and are not, which is fair enough, but why not just say that? > - prevents device property code to be cleaned up in the future This is completely unclear to me. > Resolve this mess by moving fw_devlink code to where it belongs > and hide from others. This could be more precise. Also I think that the patch is not expected to introduce functional changes, which could be mentioned here.
