On 2/28/24 12:04 AM, Dan Williams wrote: > Ben Cheatham wrote: >> This patch had an outdated commit message, so here's the patch with an updated description. >> >> I also realized that I was wrong about letting CXL 2.0+ error types (discussed a revision >> or two ago) and I wasn't actually letting them through. I've went ahead and added >> the ability to inject CXL 2.0+ error through the legacy interface. This pretty >> much amounts to returning an error for CXL 1.0/1.1 injection types in einj_error_inject() >> and instead routing them through a new einj_cxl_rch_error_inject() function called >> in einj-cxl.c >> >> If this change is too big I can send in another revision, I just wanted to avoid >> spamming the list(s). > > The thing to avoid is sending too many versions too quickly, and making > sure that upstream can reassemble the set with minimal effort. In this > case now that I have a few review comments and the fact that b4 likely > has no chance at assembling this correctly I would go ahead and fixup > those comments for a v15. Alright that makes sense. I'll put together a v15 and send it out later this week/early next week. Thanks, Ben
