On Sun, Feb 18, 2024 at 5:15 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Some recent(ish) Dell AIO devices have a backlight controller board
> connected to an UART.
>
> This UART has a DELL0501 HID with CID set to PNP0501 so that the UART is
> still handled by 8250_pnp.c. Unfortunately there is no separate ACPI device
> with an UartSerialBusV2() resource to model the backlight-controller.
>
> The next patch in this series will use acpi_quirk_skip_serdev_enumeration()
> to still create a serdev for this for a backlight driver to bind to
> instead of creating a /dev/ttyS0.
>
> This new acpi_quirk_skip_serdev_enumeration() use is not limited to Android
> X86 tablets, so move it out of the ifdef CONFIG_X86_ANDROID_TABLETS block.
...
> +#else
> +static int acpi_dmi_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
> +{
> + return 0;
> +}
> #endif
...
> static inline int
> acpi_quirk_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
> {
> *skip = false;
> return 0;
> }
> +#endif
Now you have basically two identical blocks in two files. I believe
you may reorganize the code to have only one of these.
--
With Best Regards,
Andy Shevchenko
