On 15/02/2024 00:32, Saravana Kannan wrote: > > Good point. Done. > >>> + # One or more suppliers can be marked as post initialization supplier >>> + description: >>> + List of phandles to suppliers that are not needed for initializing or >>> + resuming this device. >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + items: >>> + maxItems: 1 >> >> Rob's bot rightfully complains here about invalid syntax. > > I added these two lines based on Rob's feedback. Is the indentation > that's wrong? > > Yeah, I'm trying to run the dts checker, but I haven't be able to get > it to work on my end. See my email to Rob on the v1 series about this. > > $ make DT_CHECKER_FLAGS=-m dt_binding_check > > The best I could get out of it is a bunch of error reports on other > files and then: > ... > <snip>/Documentation/devicetree/bindings/post-init-suppliers.yaml: > ignoring, error parsing file > ... > > I also tried to use DT_SCHEMA_FILES so I can only test this one file, > but that wasn't working either: I see the errors immediately during testing, no special arguments needed: crosc64_dt_binding_check post-init-supplier.yaml make[1]: Entering directory '/home/krzk/dev/linux/linux/out' LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/post-init-supplier.example.dts ../Documentation/devicetree/bindings/post-init-supplier.yaml:84:12: [error] syntax error: mapping values are not allowed here (syntax) CHKDT Documentation/devicetree/bindings/processed-schema.json ../Documentation/devicetree/bindings/post-init-supplier.yaml:84:12: mapping values are not allowed in this context make[3]: *** [../Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/post-init-supplier.example.dts] Error 1 make[3]: *** Deleting file 'Documentation/devicetree/bindings/post-init-supplier.example.dts' make[3]: *** Waiting for unfinished jobs.... ../Documentation/devicetree/bindings/post-init-supplier.yaml:84:12: mapping values are not allowed in this context SCHEMA Documentation/devicetree/bindings/processed-schema.json /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/post-init-supplier.yaml: ignoring, error parsing file make[2]: *** [/home/krzk/dev/linux/linux/Makefile:1424: dt_binding_check] Error 2 make[1]: *** [/home/krzk/dev/linux/linux/Makefile:240: __sub-make] Error 2 make[1]: Leaving directory '/home/krzk/dev/linux/linux/out' make: *** [Makefile:240: __sub-make] Error 2 https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ I assume you develop on some older trees, because both next and v6.8-rc1 work... or standard issues: old dtschema, old yamllint. I am afraid you do it for some old Android kernel... :( Best regards, Krzysztof
