Ben Cheatham wrote: [..] > >> diff --git a/include/linux/einj-cxl.h b/include/linux/einj-cxl.h > >> new file mode 100644 > >> index 000000000000..92c0e2e37ad9 > >> --- /dev/null > >> +++ b/include/linux/einj-cxl.h > >> @@ -0,0 +1,40 @@ > >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ > >> +/* > >> + * CXL protocol Error INJection support. > >> + * > >> + * Copyright (c) 2023 Advanced Micro Devices, Inc. > >> + * All Rights Reserved. > >> + * > >> + * Author: Ben Cheatham <benjamin.cheatham@xxxxxxx> > >> + */ > >> +#ifndef CXL_EINJ_H > >> +#define CXL_EINJ_H > >> + > >> +#include <linux/pci.h> > >> + > >> +#if IS_ENABLED(CONFIG_ACPI_APEI_EINJ) > > > > Per above this needs to be IS_ENABLED(CONFIG_CXL_EINJ), otherwise what's > > the point of the config symbol? > > > [..] > I think the solution here is to move the einj_cxl functions into a new > file, gate that file by CONFIG_CXL_EINJ (or change the name to > CONFIG_EINJ_CXL to match einj-cxl.h), and add declarations of the > functions in the EINJ module used by said functions to > drivers/acpi/apei/apei-internal.h. I'm not sure of another approach at > this point, but if you have suggestions I'd be very happy to hear > them! Yes, this is the way.
