On Tue, Feb 13, 2024 at 01:14:15PM +0530, Onkarnarth wrote: > From: Onkarnath <onkarnath.1@xxxxxxxxxxx> > > As %pe is already introduced, it's better to use it in place of (%ld) for > printing errors in logs. It would enhance readability of logs. Here are some more candidates that I see regularly: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/dd.c?id=v6.7#n590 Something like: git grep "\(_info(\|_warn(\).*%d" finds a ton of them (plus a lot of unrelated hits, of course). If you were to do this for drivers/pci/, I would want them all for the whole directory in a single patch, and I would take the opportunity to make minor changes so the style is more consistent, e.g., "... failed (%pe)" or something. Bjorn
