On Tue, Feb 13, 2024 at 10:25:29AM +0000, Jonathan Cameron wrote: > On Mon, 12 Feb 2024 14:10:57 +0200 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Sun, Feb 11, 2024 at 07:25:29PM +0000, Jonathan Cameron wrote: ... > > > + for (struct fwnode_handle *child __free(fwnode_handle) = \ > > > + device_get_next_child_node(dev, NULL); child; \ > > Please, move child to a separate line, so we will easily see the all three > > parameters of the for-loop. Oh, I should withdraw above, we have other for_each macros there with a child being combined with previous line. > > That said, indent the assignment to the right as > > well. > Indent makes sense - but (to save another respin) how far? > Next tab stop will be a bit random looking but I guess nothing else > makes more sense. Just make whatever TAB stop that doesn't require adding any spaces. -- With Best Regards, Andy Shevchenko
