tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge head: 536723ad19c051cec0b5fa9793100f26c70b28d0 commit: 8c6e2196a852052fa1696cfe86d1da366f725b19 [76/104] thermal: intel: Discard trip tables after zone registration config: i386-buildonly-randconfig-001-20240213 (https://download.01.org/0day-ci/archive/20240213/202402131207.MEDK8odK-lkp@xxxxxxxxx/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240213/202402131207.MEDK8odK-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202402131207.MEDK8odK-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/thermal/intel/intel_pch_thermal.c:235:45: error: incompatible pointer to integer conversion passing 'struct thermal_trip *' to parameter of type 'int' [-Wint-conversion] 235 | nr_trips += pch_wpt_add_acpi_psv_trip(ptd, &ptd_trips[nr_trips]); | ^~~~~~~~~~~~~~~~~~~~ drivers/thermal/intel/intel_pch_thermal.c:114:74: note: passing argument to parameter 'trip' here 114 | static int pch_wpt_add_acpi_psv_trip(struct pch_thermal_device *ptd, int trip) | ^ 1 error generated. vim +235 drivers/thermal/intel/intel_pch_thermal.c 158 159 static int intel_pch_thermal_probe(struct pci_dev *pdev, 160 const struct pci_device_id *id) 161 { 162 struct thermal_trip ptd_trips[PCH_MAX_TRIPS] = { 0 }; 163 enum pch_board_ids board_id = id->driver_data; 164 struct pch_thermal_device *ptd; 165 int nr_trips = 0; 166 u16 trip_temp; 167 u8 tsel; 168 int err; 169 170 ptd = devm_kzalloc(&pdev->dev, sizeof(*ptd), GFP_KERNEL); 171 if (!ptd) 172 return -ENOMEM; 173 174 pci_set_drvdata(pdev, ptd); 175 ptd->pdev = pdev; 176 177 err = pci_enable_device(pdev); 178 if (err) { 179 dev_err(&pdev->dev, "failed to enable pci device\n"); 180 return err; 181 } 182 183 err = pci_request_regions(pdev, driver_name); 184 if (err) { 185 dev_err(&pdev->dev, "failed to request pci region\n"); 186 goto error_disable; 187 } 188 189 ptd->hw_base = pci_ioremap_bar(pdev, 0); 190 if (!ptd->hw_base) { 191 err = -ENOMEM; 192 dev_err(&pdev->dev, "failed to map mem base\n"); 193 goto error_release; 194 } 195 196 /* Check if BIOS has already enabled thermal sensor */ 197 if (WPT_TSEL_ETS & readb(ptd->hw_base + WPT_TSEL)) { 198 ptd->bios_enabled = true; 199 goto read_trips; 200 } 201 202 tsel = readb(ptd->hw_base + WPT_TSEL); 203 /* 204 * When TSEL's Policy Lock-Down bit is 1, TSEL become RO. 205 * If so, thermal sensor cannot enable. Bail out. 206 */ 207 if (tsel & WPT_TSEL_PLDB) { 208 dev_err(&ptd->pdev->dev, "Sensor can't be enabled\n"); 209 err = -ENODEV; 210 goto error_cleanup; 211 } 212 213 writeb(tsel|WPT_TSEL_ETS, ptd->hw_base + WPT_TSEL); 214 if (!(WPT_TSEL_ETS & readb(ptd->hw_base + WPT_TSEL))) { 215 dev_err(&ptd->pdev->dev, "Sensor can't be enabled\n"); 216 err = -ENODEV; 217 goto error_cleanup; 218 } 219 220 read_trips: 221 trip_temp = readw(ptd->hw_base + WPT_CTT); 222 trip_temp &= 0x1FF; 223 if (trip_temp) { 224 ptd_trips[nr_trips].temperature = GET_WPT_TEMP(trip_temp); 225 ptd_trips[nr_trips++].type = THERMAL_TRIP_CRITICAL; 226 } 227 228 trip_temp = readw(ptd->hw_base + WPT_PHL); 229 trip_temp &= 0x1FF; 230 if (trip_temp) { 231 ptd_trips[nr_trips].temperature = GET_WPT_TEMP(trip_temp); 232 ptd_trips[nr_trips++].type = THERMAL_TRIP_HOT; 233 } 234 > 235 nr_trips += pch_wpt_add_acpi_psv_trip(ptd, &ptd_trips[nr_trips]); 236 237 ptd->tzd = thermal_zone_device_register_with_trips(board_names[board_id], 238 ptd_trips, nr_trips, 239 ptd, &tzd_ops, 240 NULL, 0, 0); 241 if (IS_ERR(ptd->tzd)) { 242 dev_err(&pdev->dev, "Failed to register thermal zone %s\n", 243 board_names[board_id]); 244 err = PTR_ERR(ptd->tzd); 245 goto error_cleanup; 246 } 247 err = thermal_zone_device_enable(ptd->tzd); 248 if (err) 249 goto err_unregister; 250 251 return 0; 252 253 err_unregister: 254 thermal_zone_device_unregister(ptd->tzd); 255 error_cleanup: 256 iounmap(ptd->hw_base); 257 error_release: 258 pci_release_regions(pdev); 259 error_disable: 260 pci_disable_device(pdev); 261 dev_err(&pdev->dev, "pci device failed to probe\n"); 262 return err; 263 } 264 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
