> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Sent: Monday, February 5, 2024 1:36 PM > To: Sa, Nuno <Nuno.Sa@xxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Rafael J. Wysocki > <rafael@xxxxxxxxxx>; Frank Rowand <frowand.list@xxxxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx>; Daniel Scally <djrscally@xxxxxxxxx>; Heikki Krogerus > <heikki.krogerus@xxxxxxxxxxxxxxx>; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; > Len Brown <lenb@xxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 2/2] of: dynamic: flush devlinks workqueue before > destroying the changeset > > [External] > > On Mon, Feb 05, 2024 at 01:09:33PM +0100, Nuno Sa via B4 Relay wrote: > > From: Nuno Sa <nuno.sa@xxxxxxxxxx> > > > > Device links will drop their supplier + consumer refcounts > > asynchronously. That means that the refcount of the of_node attached to > > these devices will also be dropped asynchronously and so we cannot > > guarantee the DT overlay assumption that the of_node refcount must be 1 in > > __of_changeset_entry_destroy(). > > > > Given the above, call the new fwnode_links_flush_queue() helper to flush > > the devlink workqueue so we can be sure that all links are dropped before > > doing the proper checks. > > Have you seen my comments against v1? Hmm, not really. lei is not fetching any email (even this one - that's why I'm using my work email + awesome email client to reply). And looking directly in lore... I'm also not seeing any reply from you. Maybe there's an issue. - Nuno Sá
