On Thu, Feb 1, 2024, at 03:58, Haibo Xu wrote: > On Wed, Jan 31, 2024 at 5:33 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: >> >> On Wed, Jan 31, 2024, at 03:32, Haibo Xu wrote: >> > diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig >> > index 849c2bd820b9..525297c44250 100644 >> > --- a/drivers/acpi/numa/Kconfig >> > +++ b/drivers/acpi/numa/Kconfig >> > @@ -2,7 +2,7 @@ >> > config ACPI_NUMA >> > bool "NUMA support" >> > depends on NUMA >> > - depends on (X86 || ARM64 || LOONGARCH) >> > + depends on (X86 || ARM64 || LOONGARCH || RISCV) >> >> The dependency is no longer needed now since these are >> the four architectures that support ACPI now that IA64 >> is gone. >> >> All of them also 'select ACPI_NUMA' by default, though on >> x86 this can still be disabled by manually turning off >> CONFIG_X86_64_ACPI_NUMA. I suspect we don't actually ever >> want to turn it off on x86 either, so I guess the Kconfig >> option can just be removed entirely. >> > > Good catch! Will revert the change in the next version. > > To remove the dependency entirely, I think we need a separate patch for it. > What's your opinion? Agreed, that last bit would need to be acked by the x86 maintainers then, as it only affects them in practice. Arnd