On Tue, Jan 02, 2024 at 02:07:26PM -0700, Mark Hasemeyer wrote: > Other information besides wake capability can be provided about GPIO > IRQs such as triggering, polarity, and sharability. Use resource flags > to provide this information to the caller if they want it. > > This should keep the API more robust over time as flags are added, > modified, or removed. It also more closely matches acpi_irq_get() which > take a resource as an argument. > > Rename the function to acpi_dev_get_gpio_irq_resource() to better > describe the function's new behavior. Missing blank line. We put a commit message as $SUMARY ...blank line... $DESCRIPTION (can contain blank lines) ...blank line... $TAG block (may not contain blank lines) > Signed-off-by: Mark Hasemeyer <markhas@xxxxxxxxxxxx> ... > + unsigned long res_flags; Why not calling it irq_flags? ... > +struct resource; This... > + struct resource r = {}; > + return ret ?: r.start; ...does _not_ cover these cases. Hence ioport.h must be included. Did I miss it? -- With Best Regards, Andy Shevchenko