Agree. :)
I'll work on that problem.
Thanks,
rui
>-----Original Message-----
>From: Moore, Robert
>Sent: Saturday, March 15, 2008 5:49 AM
>To: Moore, Robert; Len Brown; Chuck Ebbert
>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; davej@xxxxxxxxxx
>Subject: RE: [PATCH] ACPI: disable stray gpe correctly
>
>I'm going to back this out until the reported problem is resolved.
>Bob
>
>
>>-----Original Message-----
>>From: Moore, Robert
>>Sent: Wednesday, March 12, 2008 2:59 PM
>>To: 'Len Brown'; Chuck Ebbert
>>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; davej@xxxxxxxxxx
>>Subject: RE: [PATCH] ACPI: disable stray gpe correctly
>>
>>This patch looked fairly benign to me, so I've committed it to the
ACPICA
>>core for the next release this week.
>>
>>The comment I added for the patch looks like this:
>>
>> /*
>> * Ignore this if the GPE is valid and not enabled.
>> *
>> * Flags is only zero if GPE is neither enabled or disabled -- it
may
>> * be a spurious or stray GPE -- disable it in the default case
below.
>> */
>> if (GpeEventInfo->Flags &&
>> (!(GpeEventInfo->Flags & ACPI_GPE_ENABLE_MASK)))
>> {
>> return_ACPI_STATUS (AE_OK);
>> }
>>
>>
>>If there are problems, I will back it out. Please let me know ASAP
what the
>>issue is in 436959.
>>
>>Thanks,
>>Bob
>>
>>
>>
>>>-----Original Message-----
>>>From: Len Brown [mailto:lenb@xxxxxxxxxx]
>>>Sent: Wednesday, March 12, 2008 1:10 PM
>>>To: Chuck Ebbert
>>>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; Moore, Robert;
davej@xxxxxxxxxx
>>>Subject: Re: [PATCH] ACPI: disable stray gpe correctly
>>>
>>>
>>>> > On Sunday 09 March 2008, Zhang, Rui wrote:
>>>> >> Disable stray GPE correctly
>>>> >> https://bugzilla.redhat.com/show_bug.cgi?id=251744
>>>> >> http://bugzilla.kernel.org/show_bug.cgi?id=6217
>>>> >>
>>>> >> Sighed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
>>>> >> ---
>>>> >> drivers/acpi/events/evgpe.c | 3 ++-
>>>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>> >>
>>>> >> Index: linux-2.6/drivers/acpi/events/evgpe.c
>>>> >>
===================================================================
>>>> >> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
>>>> >> +++ linux-2.6/drivers/acpi/events/evgpe.c
>>>> >> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
>>>> >>
>>>> >> ACPI_FUNCTION_TRACE(ev_disable_gpe);
>>>> >>
>>>> >> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
>>>> >> + if (gpe_event_info->flags &&
>>>> >> + (!(gpe_event_info->flags &
ACPI_GPE_ENABLE_MASK))) {
>>>> >> return_ACPI_STATUS(AE_OK);
>>>> >> }
>>>> >>
>>>>
>>>> Causes ACPI battery problems...
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=436959
>>>
>>>Okay, i've droppped it until 436959 can be figured out.
>>>
>>>thanks Chuck,
>>>-Len
>>>
>>>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
