Re: [PATCH v1 1/3] device property: Implement device_is_big_endian()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 18, 2023 at 12:18 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Dec 18, 2023 at 12:05:54PM +0100, Bartosz Golaszewski wrote:
> > On Mon, Dec 18, 2023 at 11:56 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > >
> > > On Mon, Dec 18, 2023 at 11:35:04AM +0100, Bartosz Golaszewski wrote:
> > > > On Fri, Dec 15, 2023 at 4:11 PM Andy Shevchenko
> > > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > > > On Fri, Dec 15, 2023 at 03:49:38PM +0100, Greg Kroah-Hartman wrote:
> > > > > > On Thu, Dec 07, 2023 at 04:19:22PM +0200, Andy Shevchenko wrote:
> > > > > > > On Wed, Nov 15, 2023 at 03:21:29PM -0500, Greg Kroah-Hartman wrote:
> > > > > > > > On Wed, Nov 15, 2023 at 03:58:54PM +0100, Bartosz Golaszewski wrote:
> > > > > > > > > On Fri, Nov 3, 2023 at 10:08 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > > > > > > > > > On Thu, Nov 2, 2023 at 4:33 PM Andy Shevchenko
> > > > > > > > > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > > > > > > > > > On Thu, Oct 26, 2023 at 03:27:30PM +0300, Andy Shevchenko wrote:
> > > > > > > > > > > > On Thu, Oct 26, 2023 at 07:25:35AM +0200, Greg Kroah-Hartman wrote:
> > > > > > > > > > > > > On Wed, Oct 25, 2023 at 09:42:57PM +0300, Andy Shevchenko wrote:
> > >
> > > ...
> > >
> > > > > > > > > > > > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > > > > > > > > >
> > > > > > > > > > > > Thank you, Greg.
> > > > > > > > > > > >
> > > > > > > > > > > > Bart, would it be still possible to take this into next?
> > > > > > > > > > > > I would like to have at least this patch applied (with the first user)
> > > > > > > > > > > > to allow conversion of others (I have some more users of new API).
> > > > > > > > > > >
> > > > > > > > > > > Okay, seems we missed v6.7 with this, can you then prepare an immutable
> > > > > > > > > > > branch / tag with this, so other maintainers can pull in case it's needed?
> > > > > > > > > > > (I have something against tty already and perhaps something else, let's
> > > > > > > > > > >  see.)
> > > > > > > > > >
> > > > > > > > > > It arrived too late in the cycle, I needed to send my PR earlier this
> > > > > > > > > > time as I was OoO this week.
> > > > > > > > >
> > > > > > > > > Greg, will you take this patch through your tree and provide me with
> > > > > > > > > an immutable tag for this cycle?
> > > > > > > >
> > > > > > > > Sure, let me catch up with patches after I return from Plumbers next
> > > > > > > > week.
> > > > > > >
> > > > > > > Hope Plumbers went well!
> > > > > >
> > > > > > Sorry for the delay, immutable tag can be found at:
> > > > > >       git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git device_is_big_endian-6.8-rc1
> > > > > > for anyone to pull from now.
> > > > >
> > > > > No problem and thank you!
> > > > >
> > > > > Bart, can you pull that? Or should I to my tree and then push with other
> > > > > GPIO patches?
> > > >
> > > > Ugh, this is rebased on top of 6.7-rc3...
> > > >
> > > > My tree is based on rc1, if I pull it, then it'll be a mess.
> > >
> > > But v6.7-rc3 is something that is already in the upstream.
> > > I don't see how it can be more "mess" with this. Whatever...
> > >
> >
> > My for-next branch is based on v6.7-rc1 (as it should IIUC) and if I
> > now pull Greg's tag, I will be sending rc1-rc3 stuff to Linus Torvalds
> > in addition to the GPIO changes for v6.8. I bet he will not appreciate
> > it.
>
> No, you will not be sending him -rc1-rc3 stuff at all, that's not how
> git works.
>
> Try it yourself and see.  Git does a "what's the changesets that are
> in this pull request and not already in mine" when determining this.
> You can see it when doing a 'git request-pull', it will only show you
> the diff of what will be sent.
>
> Also look at the 'git merge-base' output, it will show the point where
> things will start to be sent, and that will not have all of the -rc1
> through -rc3 changes in it.
>
> > Greg: Is it too late to have this rebased on top of v6.7-rc1 instead?
>
> Sorry, but yes.  But don't worry, again, git can handle all of this
> easily!  Try it locally and see.  Don't fear the 'fast-forward' :)
>

Sorry for the noise. I did try it locally and noticed that a bunch of
commits that were merged before rc3 moved "before it" in git log and
figured this is what the PR would look like. However the PR is correct
and I should have generated it before sending the email.

Thanks for a lesson in git.
Bartosz

> thanks,
>
> greg k-h
>





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux