Hi Shiju, I have some general feedback at this point before digging too deep into the details: shiju.jose@ wrote: > From: Shiju Jose <shiju.jose@xxxxxxxxxx> > > 1. Add support for CXL feature mailbox commands. > 2. Add CXL device scrub driver supporting patrol scrub control and DDR5 ECS > control features. > 3. Add scrub driver supports configuring memory scrubs in the system. > 4. Add scrub attributes for DDR5 ECS control to the memory scrub driver. For a new a subsystem that is meant to generically abstract a "memory scrub" facility the "DDR5 ECS" naming has too much precision. How much of this interface is DDR5 ECS specific and how much of it is applicable to a theoretical DDR6 scrub implementation? My primary reaction is to boil down this interface so that only generic scrub details are visible in the ABI, and DDR5 specifics are invisible in the sysfs ABI. For example the Linux NVDIMM subsystem has an address-range-scrub facility that is independent of the specific memory technology scrub mechanism. That one is based on ACPI NFIT, but I realize you also looked at enabling the ACPI RASF scrub interface. It would be useful if this patchset could plausibly enable one non-CXL scrubber along with the CXL one. > 5. Register CXL device patrol scrub and ECS with scrub control driver. > 6. Add documentation for common attributes in the scrub configure driver. Going forward, please include the Documentation in the patch that adds the new ABI, it improves the readability / story-telling of the patches. It also makes it easier to analyze which code is needed for which ABI, and whether a given ABI is justified. The regionY nomenclature in the sysfs ABI looks like a potential opportunity to align with the "memregion" id scheme. See all the callers of memregion_alloc() where those are tagging device-backed physical address ranges with a common id namespace. It would be great if the memory-scrub ABI reported failures in terms of region-ids that correlate with CXL, DAX, or NVDIMM regions. > 7. Add documentation for CXL memory device scrub control attributes. Do the CXL specifics need to be in the ABI? One thing I missed was how the series of log entries are conveyed. For CXL in contrast to what NVDIMM did for address range scrub is that CXL makes use of trace-events to emit log records. That allows the sysfs ABI to remain relatively simple, but the various trace-events can get into more protocol specific details. For example, see cxl_trigger_poison_list() and trace_cxl_poison() as a way to genericly trigger the listing of a flow of device-specific details. In other words put the DDR5 ECS specifics in the trace-event, not the sysfs ABI if possible. Lastly, dynamically defined sysfs groups are less palatable than statically defined. See cxl_region_target_visible() for a scheme for statically defining a runtime variable number of attributes. Specifically I would like to see a way to define this new subsystem without scrub_create_attrs() and all the runtime attribute definition. Overall, I like the general approach to define a common subsystem for this, and get off the treadmill of reinventing custom scrub interfaces per bus, but that also requires that it be generic enough to subsume a number of those per-bus-scrub-types.
