rockchip supports a single iommu instance and does not support multiple
IDs.
Move the per-device allocation from rk_iommu_of_xlate() and completely
delete rk_iommu_of_xlate(). The iommu instance is obtained via
iommu_of_get_single_iommu().
Don't use devm to manage the lifetime of the per-device data, this just
results in memory leaking if there are probe error/retry paths. Use the
normal lifecycle with alloc in probe_device and free in release_device.
The comment about "virtual devices" seems out of date. With today's code
the core will not call attach_device/detach_device unless dev->iommu is
set and has an ops. This can only happen if probe_device was done. Remove
the checks.
Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
---
drivers/iommu/rockchip-iommu.c | 74 +++++++++++-----------------------
1 file changed, 24 insertions(+), 50 deletions(-)
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index 2685861c0a1262..4cff06a2a24f74 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -15,6 +15,7 @@
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/iommu.h>
+#include <linux/iommu-driver.h>
#include <linux/iopoll.h>
#include <linux/list.h>
#include <linux/mm.h>
@@ -123,6 +124,7 @@ struct rk_iommudata {
static struct device *dma_dev;
static const struct rk_iommu_ops *rk_ops;
static struct iommu_domain rk_identity_domain;
+static const struct iommu_ops rk_iommu_ops;
static inline void rk_table_flush(struct rk_iommu_domain *dom, dma_addr_t dma,
unsigned int count)
@@ -896,13 +898,6 @@ static size_t rk_iommu_unmap(struct iommu_domain *domain, unsigned long _iova,
return unmap_size;
}
-static struct rk_iommu *rk_iommu_from_dev(struct device *dev)
-{
- struct rk_iommudata *data = dev_iommu_priv_get(dev);
-
- return data ? data->iommu : NULL;
-}
-
/* Must be called with iommu powered on and attached */
static void rk_iommu_disable(struct rk_iommu *iommu)
{
@@ -958,16 +953,12 @@ static int rk_iommu_enable(struct rk_iommu *iommu)
static int rk_iommu_identity_attach(struct iommu_domain *identity_domain,
struct device *dev)
{
- struct rk_iommu *iommu;
+ struct rk_iommudata *data = dev_iommu_priv_get(dev);
+ struct rk_iommu *iommu = data->iommu;
struct rk_iommu_domain *rk_domain;
unsigned long flags;
int ret;
- /* Allow 'virtual devices' (eg drm) to detach from domain */
- iommu = rk_iommu_from_dev(dev);
- if (!iommu)
- return -ENODEV;
-
rk_domain = to_rk_domain(iommu->domain);
dev_dbg(dev, "Detaching from iommu domain\n");
@@ -1003,19 +994,12 @@ static struct iommu_domain rk_identity_domain = {
static int rk_iommu_attach_device(struct iommu_domain *domain,
struct device *dev)
{
- struct rk_iommu *iommu;
+ struct rk_iommudata *data = dev_iommu_priv_get(dev);
+ struct rk_iommu *iommu = data->iommu;
struct rk_iommu_domain *rk_domain = to_rk_domain(domain);
unsigned long flags;
int ret;
- /*
- * Allow 'virtual devices' (e.g., drm) to attach to domain.
- * Such a device does not belong to an iommu group.
- */
- iommu = rk_iommu_from_dev(dev);
- if (!iommu)
- return 0;
-
dev_dbg(dev, "Attaching to iommu domain\n");
/* iommu already attached */
@@ -1115,20 +1099,30 @@ static void rk_iommu_domain_free(struct iommu_domain *domain)
kfree(rk_domain);
}
-static struct iommu_device *rk_iommu_probe_device(struct device *dev)
+static struct iommu_device *rk_iommu_probe_device(struct iommu_probe_info *pinf)
{
+ struct device *dev = pinf->dev;
struct rk_iommudata *data;
struct rk_iommu *iommu;
- data = dev_iommu_priv_get(dev);
- if (!data)
- return ERR_PTR(-ENODEV);
+ iommu = iommu_of_get_single_iommu(pinf, &rk_iommu_ops, -1,
+ struct rk_iommu, iommu);
+ if (IS_ERR(iommu))
+ return ERR_CAST(iommu);
+ if (iommu_of_num_ids(pinf) != 1)
+ return ERR_PTR(-EINVAL);
- iommu = rk_iommu_from_dev(dev);
+ data = kzalloc(sizeof(*data), GFP_KERNEL);
+ if (!data)
+ return ERR_PTR(-ENOMEM);
+ data->iommu = iommu;
+ data->iommu->domain = &rk_identity_domain;
data->link = device_link_add(dev, iommu->dev,
DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME);
+ dev_iommu_priv_set(dev, data);
+
return &iommu->iommu;
}
@@ -1137,37 +1131,17 @@ static void rk_iommu_release_device(struct device *dev)
struct rk_iommudata *data = dev_iommu_priv_get(dev);
device_link_del(data->link);
-}
-
-static int rk_iommu_of_xlate(struct device *dev,
- struct of_phandle_args *args)
-{
- struct platform_device *iommu_dev;
- struct rk_iommudata *data;
-
- data = devm_kzalloc(dma_dev, sizeof(*data), GFP_KERNEL);
- if (!data)
- return -ENOMEM;
-
- iommu_dev = of_find_device_by_node(args->np);
-
- data->iommu = platform_get_drvdata(iommu_dev);
- data->iommu->domain = &rk_identity_domain;
- dev_iommu_priv_set(dev, data);
-
- platform_device_put(iommu_dev);
-
- return 0;
+ kfree(data);
}
static const struct iommu_ops rk_iommu_ops = {
.identity_domain = &rk_identity_domain,
.domain_alloc_paging = rk_iommu_domain_alloc_paging,
- .probe_device = rk_iommu_probe_device,
+ .probe_device_pinf = rk_iommu_probe_device,
.release_device = rk_iommu_release_device,
.device_group = generic_single_device_group,
.pgsize_bitmap = RK_IOMMU_PGSIZE_BITMAP,
- .of_xlate = rk_iommu_of_xlate,
+ .of_xlate = iommu_dummy_of_xlate,
.default_domain_ops = &(const struct iommu_domain_ops) {
.attach_dev = rk_iommu_attach_device,
.map_pages = rk_iommu_map,
--
2.42.0
