On Thu, Oct 19, 2023 at 12:21:12PM -0700, Dmitry Torokhov wrote: > On Thu, Oct 19, 2023 at 08:34:56PM +0300, Andy Shevchenko wrote: > > When consolidating GPIO lookups in ACPI code, the debug messaging > > had been broken and hence lost a bit of sense. Restore debug > > messaging in gpiod_find_and_request() when configuring the GPIO > > line via gpiod_configure_flags(). > > Could you give an example of the before/after messages to show exavtly > what is being improved? Before your patch: [ 5.266823] gpio-96 (ACPI:OpRegion): no flags found for ACPI:OpRegion [ 14.182994] gpio-40 (?): no flags found for gpios After your patch: [ 5.085048] gpio-96 (ACPI:OpRegion): no flags found for ACPI:OpRegion [ 13.401402] gpio-40 (?): no flags found for (null) After this patch: [ 3.871185] gpio-96 (ACPI:OpRegion): no flags found for ACPI:OpRegion [ 12.491998] gpio-40 (?): no flags found for gpios ... Looking at this it's definitely a fix. -- With Best Regards, Andy Shevchenko
