Buffer variable for result (value32) is not initialized.
This can lead to unexpected behavior, if underlying platform-specific
raw_pci_read fails to report error (uninitialized value will be treated
as valid pci-read result), or exposition of unexpected data to PCI
config space reader.
Zeroing of buffer value addresses the later problem and makes the
behavior in the former case somewhat more predictable.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: c5f0231ee6b0 ("ACPICA: Fix acpi_os_read_pci_configuration prototype")
Signed-off-by: Nikita Kiryushin <kiryushin@xxxxxxxx>
---
drivers/acpi/osl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index c09cc3c68633..d3c0f7f01a29 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -788,7 +788,7 @@ acpi_os_read_pci_configuration(struct acpi_pci_id
*pci_id, u32 reg,
u64 *value, u32 width)
{
int result, size;
- u32 value32;
+ u32 value32 = 0U;
if (!value)
return AE_BAD_PARAMETER;
--
2.34.1
