On Wed, Nov 01, 2023 at 10:05:02AM +0000, Sakari Ailus wrote: > On Wed, Nov 01, 2023 at 11:51:35AM +0200, Andy Shevchenko wrote: > > On Wed, Nov 01, 2023 at 11:07:34AM +0200, Sakari Ailus wrote: > > > Hi all, > > > > > > The of_parse_phandle_with_args() accepts NULL args but > > > fwnode_property_get_reference_args() does not currently, in its ACPI or > > > software node implementations. Fix this. > > > > The last sentence assumes Fixes tag(s) which I can't see. > > This obviously hasn't been an issue for the existing users so backporting > it has little value. From API consistency PoV this does matter though. Fixes is not always about backporting. But if some code starts using that and needs to be backported with that in mind... > I can add a Fixes: tag if you like. I think some clarity needs to be done, either Fixes tag(s) or changing language to explain that this is an improvement and not an immediate fix. -- With Best Regards, Andy Shevchenko
