Hi Sakari, On Tue, Oct 31, 2023 at 11:33 AM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > Hi Rafael, [cut] > > The v2 addresses at least 3 issues found in the v1 by code inspection: > > > > * A port_count field incrementation was missing in acpi_mipi_scan_crs_csi2(), > > so its value for all of the devices having CSI2 resources in _CRS was always > > 1 (and it should be equal to the number of valid CSI2 connection resources). > > > > * Some acpi_mipi_crs_csi2_list members could be freed prematurely, so they were > > inaccessible when extract_crs_csi2_conn_info() attempted to access them. > > > > * A check of remote_swnodes() against NULL was missing, which could result in > > a crash in a case when the swnodes memory could not be allocated for some > > acpi_mipi_crs_csi2_list entries. > > > > Apart from that, it rearranges the code somewhat to make it easier to follow > > and to avoid premature freeing of memory in it in general and the new file > > added by it is now called mipi-di.c (instead of mipi-disco-imaging.c) for > > compactness. > > > > The series is based on current linux-next. > > Thanks for the update. I've tested this and I can confirm it works, to the > extent implemented in the set. The rest can be implemented on top > (mainly replicating properties). Thanks for testing! > I'll comment on a few patches in the set. > > Do you prefer to make the changes or shall I? I presume them to be fairly > minor. I can make the changes.
