* Vincent Guittot <vincent.guittot@xxxxxxxxxx> wrote: > +/* Look up the max frequency in DMI */ > +static u64 cppc_get_dmi_max_khz(void) > +{ > + u16 mhz = 0; > + > + dmi_walk(cppc_find_dmi_mhz, &mhz); > + > + /* > + * Real stupid fallback value, just in case there is no > + * actual value set. > + */ > + mhz = mhz ? mhz : 1; > + > + return (1000 * mhz); Nit, and I realize this is pre-existing code, but 'return' is a keyword, not a function, so the parentheses are not needed. Thanks, Ingo