On Sunday 24 February 2008, Carlos Corbacho wrote:
> The current device detection error messages are all copy & pasted - make
> them more descriptive so it's easier to see where in the code a problem
> occurs.
>
> Signed-off-by: Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>
> ---
>
> drivers/misc/acer-wmi.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
>
> diff --git a/drivers/misc/acer-wmi.c b/drivers/misc/acer-wmi.c
> index d1d64db..99beeb8 100644
> --- a/drivers/misc/acer-wmi.c
> +++ b/drivers/misc/acer-wmi.c
> @@ -1052,11 +1052,12 @@ static int __init acer_wmi_init(void)
>
> if (wmi_has_guid(WMID_GUID2) && interface) {
> if (ACPI_FAILURE(WMID_set_capabilities())) {
> - printk(ACER_ERR "Unable to detect available devices\n");
> + printk(ACER_ERR "Unable to detect available WMID ");
While KERN_CONT will shut up checkpatch, I don't think
it isn't what you want here
since acer_wmi is loaded well afer we've gone SMP.
> + printk(KERN_CONT "devices\n");
Instead, to get under 80 columns, you simpmly want to do something like this:
printk(ACER_ERR "Unable to detect available WMID "
"devices");
as the pre-processor will concatenate adjacent strings for you at build time.
-Len
> return -ENODEV;
> }
> } else if (!wmi_has_guid(WMID_GUID2) && interface) {
> - printk(ACER_ERR "Unable to detect available devices\n");
> + printk(ACER_ERR "No WMID device detection method found\n");
> return -ENODEV;
> }
>
> @@ -1064,7 +1065,8 @@ static int __init acer_wmi_init(void)
> interface = &AMW0_interface;
>
> if (ACPI_FAILURE(AMW0_set_capabilities())) {
> - printk(ACER_ERR "Unable to detect available devices\n");
> + printk(ACER_ERR "Unable to detect available AMW0 ");
> + printk(KERN_CONT "devices\n");
> return -ENODEV;
> }
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
