Wilczynski, Michal wrote: > > > On 10/2/2023 3:54 PM, Andy Shevchenko wrote: > > The acpi_evaluate_dsm_typed() provides a way to check the type of the > > object evaluated by _DSM call. Use it instead of open coded variant. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > --- > > drivers/acpi/nfit/core.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > > index f96bf32cd368..280da408c02c 100644 > > --- a/drivers/acpi/nfit/core.c > > +++ b/drivers/acpi/nfit/core.c > > @@ -1737,9 +1737,8 @@ __weak void nfit_intel_shutdown_status(struct nfit_mem *nfit_mem) > > if ((nfit_mem->dsm_mask & (1 << func)) == 0) > > return; > > > > - out_obj = acpi_evaluate_dsm(handle, guid, revid, func, &in_obj); > > - if (!out_obj || out_obj->type != ACPI_TYPE_BUFFER > > - || out_obj->buffer.length < sizeof(smart)) { > > + out_obj = acpi_evaluate_dsm_typed(handle, guid, revid, func, &in_obj, ACPI_TYPE_BUFFER); > > This line is 90 characters long, wouldn't it be better to split it ? 100 characters is allowed these days. > > + if (!out_obj || out_obj->buffer.length < sizeof(smart)) { > > dev_dbg(dev->parent, "%s: failed to retrieve initial health\n", > > dev_name(dev)); > > While at it maybe fix alignment ? :-) Life is too short to fiddle with indentation. For old code leave it alone, for new code just use clang-format.