On Tue, Oct 17, 2023 at 12:45 PM Wilczynski, Michal <michal.wilczynski@xxxxxxxxx> wrote: > > > On 10/6/2023 7:30 PM, Michal Wilczynski wrote: > > NFIT driver uses struct acpi_driver incorrectly to register itself. > > This is wrong as the instances of the ACPI devices are not meant > > to be literal devices, they're supposed to describe ACPI entry of a > > particular device. > > > > Use platform_driver instead of acpi_driver. In relevant places call > > platform devices instances pdev to make a distinction with ACPI > > devices instances. > > > > NFIT driver uses devm_*() family of functions extensively. This change > > has no impact on correct functioning of the whole devm_*() family of > > functions, since the lifecycle of the device stays the same. It is still > > being created during the enumeration, and destroyed on platform device > > removal. > > > > Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > Signed-off-by: Michal Wilczynski <michal.wilczynski@xxxxxxxxx> > > Hi Dan, > Rafael already reviewed this patch series and merged patches > that he likes. We're waiting on your input regarding two NFIT > commits in this series. I actually haven't looked at the NFIT patches in this series myself and this is not urgent at all IMV. Thanks!
