On Thursday 06 March 2008, Johann Felix Soden wrote:
> From: Johann Felix Soden <johfel@xxxxxxxxxxxxxxxxxxxxx>
>
> Since "ff_gbl_lock" has a length of 10 chars and is copied with sprintf to
> char buffer[10], there is a problem because of the closing zero byte. We
> need char buffer[11].
"ff_gbl_lock" is 11 characters, and sprintf adds a null, so
buffer should be 12, yes?
looking at this code, i think i must have been asleep when i wrote it.
the strings such as "ff_gbl_lock" are in kernel data, and then
we copy to a local stack buffer, and then we copy to a heap
buffer -- when we should have just pointed to the data.
oh well, cleanup for .26...
>
> Signed-off-by: Johann Felix Soden <johfel@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/acpi/system.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/system.c b/drivers/acpi/system.c
> index 55cf4c0..037b679 100644
> --- a/drivers/acpi/system.c
> +++ b/drivers/acpi/system.c
> @@ -319,7 +319,7 @@ void acpi_irq_stats_init(void)
> goto fail;
>
> for (i = 0; i < num_counters; ++i) {
> - char buffer[10];
> + char buffer[11];
> char *name;
>
> if (i < num_gpes)
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
